-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add health status reporter for storageclient #6
Conversation
Install ceph-CSI driver based on the kubernetes version where the ocs-client operator is running. Signed-off-by: Madhu Rajanna <[email protected]>
Adding storageClient CR which supports anboarding and offboarding new storageclients to the provider cluster. A single storageclient can exists in a single namespace. If someone tries to create one more storageclient it will fail. Signed-off-by: Madhu Rajanna <[email protected]>
Adding storageClassclaim CR which supports requesting for cephfs and rbd storageclass Signed-off-by: Madhu Rajanna <[email protected]>
Adding the status health of the storageclient to the provider cluster. Signed-off-by: Madhu Rajanna <[email protected]>
13b7404
to
a411137
Compare
increase golangci-lint to the higher value. Signed-off-by: Madhu Rajanna <[email protected]>
91c8cb3
to
3c83672
Compare
As part of status-report update the monitor IP for the connected provider cluster. Signed-off-by: Madhu Rajanna <[email protected]>
7aae1c7
to
2b390c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be taking a look through this PR as a collection of all work thus far, as I didn't see anything to indicate these could really be taken in isolation.
In general, I want to see some of the commits restructured along these lines:
- Move vendor changes (including go.sum changes) into their own commit(s?)
- Keep generated code + manifest changes in their own commits, ideally following the relevant code commits that produced these changes
- Keep github workflow changes int heir own commit
- Keep ancillary repository changes (e.g. Makefile, Dockerfile) in their own commits
Doing these things should make reviews, rebases, and bisects smoother and easier to understand. I'll still do an initial review in the meantime.
tried to address all the above in #7 , dropping this pr. |
Adding the status health report of the storage client to the provider cluster.
Signed-off-by: Madhu Rajanna [email protected]